Post title reverts to `_post_title`

[JustinSainton]

Steps to Reproduce

1. Go to any existing page's edit screen.
2. Change the title and update the page.
3. Tailor the page - make any change and save it.
4. Go back to edit screen, see title is reverted to previous title.

This is due to this function:

tailor/includes/class-panels.php

Lines 384 to 394 in fd69c68

	public function update_post_title( $post_id ) {
	$saved_title = get_post_meta( $post_id, '_post_title', true );
	if ( false != $saved_title ) {
	wp_update_post( array(
	'ID' => $post_id,
	'post_title' => $saved_title
	) );
	}
	}

I'm unclear at the moment on what the best way to address this. Current working theory is that it probably makes sense to hook into post title changes and update the _post_title meta key so they stay synced in both directions.

[conwaydev]

To override this we just remove_all_actions( 'tailor_save_settings' );, but yeah this is a pain.

[JustinSainton]

Definitely! Considered that approach as well, but it seemed prone to unintended consequences.

Our likely approach here will be something like this in a functionality plugin:

remove_action( 'tailor_save_settings', array( tailor_panels(), 'update_post_title' ) );

This approach likely works for us as we don't anticipate making use of the title field in Tailor that this affects.

[conwaydev]

oh for sure, that too!