Add support for setting embed image width and height

[kicker10BOG]

Summary

Add support for setting image size in embeds: set width and height

What is the feature request for?

The core library

The Problem

Discord supports setting the width and height in embed images. When it's not set, images can be quite blurry. Thumbnails too.
https://discord.com/developers/docs/resources/message#embed-object-embed-image-structure

The Ideal Solution

Add width and height parameters to Embed.set_image() and Embed.set_thumbnail()

The Current Solution

There is no current solution. Images are just blurry.

Additional Context

When I send out alerts using PHP and set the image size, they look great.

[shiftinv]

The API doesn't support setting height or width on embed images yourself, they're receive-only:

For the embed object, you can set every field except type (it will be rich regardless of if you try to set it), provider, video, and any height, width, or proxy_url values for images.

https://discord.com/developers/docs/resources/message#create-message-limitations

If images are blurry, it's unlikely to be a library issue, but if you have some code to reproduce the problem it might help narrow down the problem.

[kicker10BOG]

disnake doesn't support it, but discord does. When disnake responds to a command with an image in the embed, it is blurry when I click on it. However, when one of the automatic posts from php code is executed and sends the same image, it is not blurry because I can set the width and height.
Here is the embed object in my php code. See how I can set the height and width for both the image and thumbnaii? When I don't do that, they are blurry when I click on them.

                        $embed = (object) [
                            'title' => teamDiscordEmoji($game->awayTeam->logoId) . "{$game->awayTeam->displayName} {$game->awayTeam->record} {$game->awayScore} AT {$game->homeScore} " . teamDiscordEmoji($game->homeTeam->logoId) . "{$game->homeTeam->displayName} {$game->homeTeam->record}",
                            'color' => ActiveDiscordBot::getColorInt($bot->settings->color),
                            'url' => $this->league->useWP ? ($this->league->wordpressUrl . '/' . ($this->league->wordpressPrefix ? $this->league->wordpressPrefix . '/' : '') . "game/$game->id>") : $game->url,
                            'thumbnail' => (object) [
                                "url" => $thumbImg ? $thumbImg->url : route('api.madden.league.games.thumbnail', ['league' => $this->league->slug, 'game' => $game->id, 'seed' => now()->timestamp]),
                                "width" => 1280,
                                "height" => 720,
                            ],
                            'image' => (object) [
                                'url' => route('api.madden.league.games.recap', ['league' => $this->league->slug, 'game' => $game->id]),
                                'width' => 2048,
                                'height' => 1152,
                            ],
                            'author' => (object) [
                                "name" => $this ? "{$this->league->abbr} on " . config("app.name", "MyMadden") : "MyMadden",
                                "icon_url" => route('pages.home') . '/favicons/favicon-32x32.png',
                            ],
                            'description' => "{$awayUser->ownerStr} AT {$homeUser->ownerStr}\n{$game->calendarYear} | {$game->stage} | {$game->weekTitle}",
                            'content' => "",
                        ];

I think disnake should add the ability to set height and width.

[kicker10BOG]

Oh, and what you quoted was for the embed object itself, not the image or thumbmail. They both let you set width and height.

[shiftinv]

Oh, and what you quoted was for the embed object itself, not the image or thumbmail.

"[...] can set every field except [...] any height, width, or proxy_url values for images."
(see also discord/discord-api-docs#5300, for instance)

They're mentioned in the table since those fields are received from the API, and while you can technically send them to the API, they will be ignored:

$ curl -s -X POST -H 'Content-Type: application/json' ${WEBHOOK_URL}?wait=1 \
  -d '{"embeds": [{"image": {"url": "https://placecats.com/300/200", "width": 123, "height": 456}}]}' \
  | jq '.embeds[0].image.width'
300

Not sure how you're getting a blurry image one way but not the other, especially if Discord is just pulling it from the same URL.

[kicker10BOG]

Either I'm imagining things or the documentation needs to be updated. Either way, it wouldn't hurt to provide the option in disnake.