Bug: UI scaling doubles window size

[dromer]

It seems that when using a scaling factor the window size is scaled twice.

For instance using DPF_SCALE_FACTOR=1.5 and a window that is 707x444:

DPF thinks it's correct: [dpf] createNextWindow 1060 666 1.500000
However the actual window size: Width: 1590 Height: 999

This is exactly 1.5*1.5 on both sides.

Tested on X11 and latest develop.

[falkTX]

Seems fine to me on X11 and standalones, is this maybe on embed plugins only?

Also, make sure you are not doubling the scale yourself. the UI constructor has a 3rd argument for auto-scaling, if used and also calling setSize() in the UI constructor yourself, you can get to double scaling.

[dromer]

heuhm, did the signature change then? I haven't had this issue before and had done extensive scaling tests in the past.

I have only set this argument to true and am not using setSize(): https://github.com/Wasted-Audio/wstd-eq/blob/master/override/HeavyDPF_WSTD_EQ_UI.cpp#L35

[falkTX]

The extra arg has been there for a while, I might have wrongly used it before in some examples not sure now.

Please do a few tests, so:

1. remove setGeometryConstraints from the UI code
2. also remove the extra ", true" constructor arg

[dromer]

with 1. the window size is still too big and the rest of the rendering is broken:

with 2. it seems to be correct now? o.O

[dromer]

Leaving setGeometryConstraints and only removing , true from the UI constructor works correctly too.

The behavior of this scaling has most definitely changed then.

[dromer]

So with this diff everything seems to work now. Should I apply this to all my plugins then?

diff --git a/override/HeavyDPF_WSTD_EQ_UI.cpp b/override/HeavyDPF_WSTD_EQ_UI.cpp
index 7f39da3..ca1148e 100644
--- a/override/HeavyDPF_WSTD_EQ_UI.cpp
+++ b/override/HeavyDPF_WSTD_EQ_UI.cpp
@@ -32,11 +32,9 @@ public:
       The UI should be initialized to a default state that matches the plugin side.
     */
     ImGuiPluginUI()
-        : UI(DISTRHO_UI_DEFAULT_WIDTH, DISTRHO_UI_DEFAULT_HEIGHT, true),
+        : UI(DISTRHO_UI_DEFAULT_WIDTH, DISTRHO_UI_DEFAULT_HEIGHT),
           fResizeHandle(this)
     {
-        setGeometryConstraints(DISTRHO_UI_DEFAULT_WIDTH, DISTRHO_UI_DEFAULT_HEIGHT, true);
-
         ImGuiIO& io(ImGui::GetIO());
 
         ImFontConfig fc;

[falkTX]

That doesnt look quite right, there shouldnt be auto-scaling without it being requested explicitly.

Best to not merge that as-is, this seems to me like a DPF regression.

[dromer]

Ok, yeah this responds to scale factor already which seems odd as this was an explicit setting previously.