Security fix #524: prevent path traversal, unsafe eval, and key leakage#531
Closed
kallal79 wants to merge 1 commit intoControlCore-Project:devfrom
Closed
Security fix #524: prevent path traversal, unsafe eval, and key leakage#531kallal79 wants to merge 1 commit intoControlCore-Project:devfrom
kallal79 wants to merge 1 commit intoControlCore-Project:devfrom
Conversation
…eval, and key leakage
pradeeban
reviewed
Apr 3, 2026
| except: | ||
| init_simtime_ym = "[0.0, 0.0, 0.0]" | ||
|
|
||
| if apikey: |
Member
There was a problem hiding this comment.
That was a debug log. Ideally it shouldn't be there. But in any case, it was printing the actual apikey. Now you are printing a string. That makes the log meaningless.
Member
|
There are several merge conflicts. I believe you developed against the main and then changed the PR to dev. concore/concore.py demo/pwrap.py I close this PR. Please do not re-attempt this PR as I see more of a risk in potential to break the core concore protocol. |
Author
|
OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files changed:
concore/concore.py
concore/mkconcore.py
concore/concore.hpp
demo/pwrap.py
ratc/pwrap.py