generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 416
Glasgow | 26-ITP-Jan | Mohsen Gharaei | Sprint 1 | Wireframe #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mohsen-tech12
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
Mohsen-tech12:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−14
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,26 +8,54 @@ | |
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
| <h1>README, Wireframe, and branch</h1> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| This page is going to talk about README, Wireframe, and branch in Git. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <article> <!-- article 1 --> | ||
| <img src="https://miro.medium.com/v2/resize:fit:2000/format:webp/1*ERiYzo27N2v3fV5vl5kt5g.png" alt="Top" /> | ||
| <h2>README</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| Picture above shows an example of README file in GitHub. README files tell people a summary of your project and what is your project about and how they can use your project. a good README | ||
| file will help people to understand your repo better. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| <a href="https://wengerk.medium.com/why-having-a-readme-on-your-internal-project-is-essential-c85cb9dd8e65">Read more</a> | ||
| </article> <!-- article 1 --> | ||
|
|
||
| <article> <!-- article 2 --> | ||
| <img src="https://public-images.interaction-design.org/literature/articles/materials/ElementsofaWireframe.png" alt="Left" /> | ||
| <h2>Wireframe</h2> | ||
| <p> | ||
| A wireframe is used to plan the structure of a website before designing it. It clarifies layout and structure. | ||
|
|
||
| </p> | ||
| <a href="https://www.experienceux.co.uk/faqs/what-is-wireframing/">Read more</a> | ||
| </article> <!-- article 2 --> | ||
|
|
||
| <article> <!-- article 3 --> | ||
| <img src="https://res.cloudinary.com/snyk/image/upload/f_auto,w_2560,q_auto/v1615821731/wordpress-sync/image1-11.png" alt="Right" /> | ||
| <h2>Branch</h2> | ||
| <p> | ||
| Branches are useful when the user wants to change parts of the code without affecting the main codebase. | ||
| </p> | ||
| <a href="https://www.w3schools.com/git/git_branch.asp">Read more</a> | ||
| </article> <!-- article 3 --> | ||
|
|
||
| </main> | ||
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| </footer> | ||
| </footer> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add something to the footer so we can test that it works? |
||
|
|
||
| </body> | ||
| </html> | ||
| <!DOCTYPE html> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is this block of html at the bottom doing? |
||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compare the two bottom articles. Do their layouts look symmetrical?