Add support for DDL generation/migrations #3
alex-clickhouseef-cli-smoke.yml
on: pull_request
dotnet-ef integration tests
50s
Annotations
3 errors and 10 warnings
|
dotnet-ef integration tests
Process completed with exit code 1.
|
|
dotnet-ef integration tests
Assets file '/home/runner/work/ClickHouse.EntityFrameworkCore/ClickHouse.EntityFrameworkCore/test/EFCore.ClickHouse.DesignSmoke/obj/project.assets.json' not found. Run a NuGet package restore to generate this file.
|
|
dotnet-ef integration tests
Assets file '/home/runner/work/ClickHouse.EntityFrameworkCore/ClickHouse.EntityFrameworkCore/test/EFCore.ClickHouse.DesignSmoke/obj/project.assets.json' not found. Run a NuGet package restore to generate this file.
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Metadata/Conventions/ClickHouseConventionSetBuilder.cs#L38
Change type of parameter 'conventions' from 'System.Collections.Generic.IList<Microsoft.EntityFrameworkCore.Metadata.Conventions.IEntityTypeBaseTypeChangedConvention>' to 'System.Collections.Generic.List<Microsoft.EntityFrameworkCore.Metadata.Conventions.IEntityTypeBaseTypeChangedConvention>' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Metadata/Internal/ClickHouseAnnotationProvider.cs#L47
Do not use Enumerable methods on indexable collections. Instead use the collection directly. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1826)
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Migrations/Internal/ClickHouseMigrationDatabaseLock.cs#L17
Change ClickHouseMigrationDatabaseLock.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Migrations/Internal/ClickHouseMigrationDatabaseLock.cs#L19
Change ClickHouseMigrationDatabaseLock.DisposeAsync() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Migrations/Internal/ClickHouseMigrationsAnnotationProvider.cs#L7
Microsoft.EntityFrameworkCore.Migrations.MigrationsAnnotationProviderDependencies is an internal API that supports the Entity Framework Core infrastructure and not subject to the same compatibility standards as public APIs. It may be changed or removed without notice in any release.
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseModelValidator.cs#L97
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseModelValidator.cs#L84
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseModelValidator.cs#L72
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseModelValidator.cs#L39
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
|
|
dotnet-ef integration tests:
src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseOptionsExtension.cs#L41
In member RelationalOptionsExtension ClickHouseOptionsExtension.WithConnection(DbConnection? connection, bool contextOwnsConnection = false), change parameter name contextOwnsConnection to owned in order to match the identifier as it has been declared in RelationalOptionsExtension RelationalOptionsExtension.WithConnection(DbConnection? connection, bool owned) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
|