Skip to content

add support for variant and dynamic #23

add support for variant and dynamic

add support for variant and dynamic #23

Triggered via pull request March 18, 2026 09:51
Status Success
Total duration 1m 24s
Artifacts

tests.yml

on: pull_request
.NET 10.0
52s
.NET 10.0
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
.NET 10.0: src/EFCore.ClickHouse/Storage/Internal/ClickHouseDataSourceManager.cs#L41
Change ClickHouseDataSourceManager.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
.NET 10.0: src/EFCore.ClickHouse/Storage/Internal/Mapping/ClickHouseTimeSpanTypeMapping.cs#L48
The behavior of 'long.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'ClickHouseTimeSpanTypeMapping.GenerateNonNullSqlLiteral(object)' with a call to 'long.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
.NET 10.0: src/EFCore.ClickHouse/Query/Internal/ClickHouseParameterBasedSqlProcessor.cs#L17
In member Expression ClickHouseParameterBasedSqlProcessor.ProcessSqlNullability(Expression queryExpression, ParametersCacheDecorator decorator), change parameter name decorator to Decorator in order to match the identifier as it has been declared in Expression RelationalParameterBasedSqlProcessor.ProcessSqlNullability(Expression queryExpression, ParametersCacheDecorator Decorator) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)
.NET 10.0: src/EFCore.ClickHouse/Storage/Internal/ClickHouseDatabaseCreator.cs#L207
The behavior of 'Convert.ToBoolean(object)' could vary based on the current user's locale settings. Replace this call in 'ClickHouseDatabaseCreator.HasTablesCoreAsync(DbConnection, string, CancellationToken)' with a call to 'Convert.ToBoolean(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
.NET 10.0: src/EFCore.ClickHouse/Storage/Internal/ClickHouseDatabaseCreator.cs#L193
The behavior of 'Convert.ToBoolean(object)' could vary based on the current user's locale settings. Replace this call in 'ClickHouseDatabaseCreator.HasTablesCore(DbConnection, string)' with a call to 'Convert.ToBoolean(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
.NET 10.0: src/EFCore.ClickHouse/Storage/Internal/ClickHouseDatabaseCreator.cs#L181
The behavior of 'Convert.ToBoolean(object)' could vary based on the current user's locale settings. Replace this call in 'ClickHouseDatabaseCreator.DatabaseExistsAsync(DbConnection, string, CancellationToken)' with a call to 'Convert.ToBoolean(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
.NET 10.0: src/EFCore.ClickHouse/Storage/Internal/ClickHouseDatabaseCreator.cs#L171
The behavior of 'Convert.ToBoolean(object)' could vary based on the current user's locale settings. Replace this call in 'ClickHouseDatabaseCreator.DatabaseExists(DbConnection, string)' with a call to 'Convert.ToBoolean(object, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
.NET 10.0: src/EFCore.ClickHouse/Query/Internal/ClickHouseSqlNullabilityProcessor.cs#L164
Change return type of method 'VisitRowValueExpression' from 'Microsoft.EntityFrameworkCore.Query.SqlExpressions.SqlExpression' to 'ClickHouse.EntityFrameworkCore.Query.Expressions.Internal.ClickHouseRowValueExpression' for improved performance (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1859)
.NET 10.0: src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseModelValidator.cs#L36
For improved performance, use the LoggerMessage delegates instead of calling 'LoggerExtensions.Log(ILogger, LogLevel, string?, params object?[])' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1848)
.NET 10.0: src/EFCore.ClickHouse/Infrastructure/Internal/ClickHouseOptionsExtension.cs#L41
In member RelationalOptionsExtension ClickHouseOptionsExtension.WithConnection(DbConnection? connection, bool contextOwnsConnection = false), change parameter name contextOwnsConnection to owned in order to match the identifier as it has been declared in RelationalOptionsExtension RelationalOptionsExtension.WithConnection(DbConnection? connection, bool owned) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1725)