Time Error

[Nathanwoodburn]

I'm getting time error. It has been happening since I installed the wrapper.

[Cldfire]

Interesting, are you using one of the compiled binaries available for download from the releases page on this GitHub repo or did you compile the binary yourself? And what OS / OS version are you running it on?

[Nathanwoodburn]

I compiled it on Ubuntu Linux.

[Cldfire]

Gotcha. So there's a .cargo/config file that's supposed to set a compilation flag to stop that from happening:

mc-server-wrapper/.cargo/config.toml

Lines 1 to 5 in c4ed71e

	[build]
	# See https://github.com/time-rs/time/issues/293#issuecomment-1005002386. The
	# unsoundness here is not in the `time` library, but in the Rust stdlib, and as
	# such it needs to be fixed there.
	rustflags = "--cfg unsound_local_offset"

It's possible that either cargo isn't picking up the compilation flag when you're compiling it locally (which I'm not sure how to direct you to debug) or that there's an error determining the local offset for some other reason. You might want to try downloading the last Linux binary from https://github.com/Cldfire/mc-server-wrapper/releases and seeing if you get time in the logs with that.

The other thing you could try is editing this code:

mc-server-wrapper/mc-server-wrapper/src/logging.rs

Lines 74 to 87 in c4ed71e

	let formatted_time_now = || -> Option<String> {
	// TODO: log errors here somehow
	time::OffsetDateTime::now_local()
	.ok()
	.and_then(|datetime| datetime.format(&CONSOLE_TIMESTAMP_FORMAT).ok())
	};
	let record = format!(
	"[{}] [{}, {}]: {}",
	formatted_time_now().unwrap_or_else(|| String::from("time error")),
	record.target(),
	record.level(),
	record.args()
	);

to this:

let record = format!(
    "[{}] [{}, {}]: {}",
    time::OffsetDateTime::now_utc()
        .format(&CONSOLE_TIMESTAMP_FORMAT)
        .unwrap_or_else(|_| String::from("time error")),
    record.target(),
    record.level(),
    record.args()
);

That'll get you UTC time with no local offset, which is (seemingly) infallible. If you do that you probably want to mess with the time formatting above there and go from 12h -> 24h time too (ideally time formatting would be configurable in the config at some point).