Skip to content

Commit 77a67ad

Browse files
committed
keep backwards compatible args, but warn
1 parent 103c071 commit 77a67ad

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

chi/container.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import tarfile
1919
import time
2020
from typing import Dict, List, Optional, Tuple
21+
from warnings import warn
2122

2223
from IPython.display import HTML, display
2324
from packaging.version import Version
@@ -72,12 +73,21 @@ def __init__(
7273
image_ref: str,
7374
exposed_ports: List[str] = None,
7475
reservation_id: str = None,
76+
start: bool = True,
77+
start_timeout: int = 0,
7578
runtime: str = None,
7679
command: List[str] = None,
7780
workdir: str = None,
7881
environment: Dict[str, str] = {},
7982
device_profiles: List[str] = [],
8083
):
84+
85+
# check if values are not the defaults.
86+
if not start or start_timeout != 0:
87+
warn(
88+
"start and start_timeout are deprecated. Containers always start immmediately."
89+
)
90+
8191
self.name = name
8292
self.image_ref = image_ref
8393
self.exposed_ports = exposed_ports

0 commit comments

Comments
 (0)