Bug report in hello-blockchain smart contract

[academic-starter]

• SendRequest and SendResponse do not satisfy its specifications.
  

  blockchain/blockchain-workbench/application-and-smart-contract-samples/hello-blockchain/HelloBlockchain.sol

  Lines 25 to 34 in 1b712d6

  	function SendRequest(string memory requestMessage) public
  	{
  	if (Requestor != msg.sender)
  	{
  	revert();
  	}
  	RequestMessage = requestMessage;
  	State = StateType.Request;
  	}

blockchain/blockchain-workbench/application-and-smart-contract-samples/hello-blockchain/HelloBlockchain.sol

Lines 37 to 44 in 1b712d6

	function SendResponse(string memory responseMessage) public
	{
	Responder = msg.sender;
	// call ContractUpdated() to record this action
	ResponseMessage = responseMessage;
	State = StateType.Respond;
	}

As documented by its following specification, SendRequest is only available when previous message has been responded, a.k.a., Respond state while SendResponse is only available when there is a request message, a.k.a., Request state.

blockchain/blockchain-workbench/application-and-smart-contract-samples/hello-blockchain/HelloBlockchain.json

Lines 108 to 147 in 1b712d6

	"States": [
	{
	"Name": "Request",
	"DisplayName": "Request",
	"Description": "...",
	"PercentComplete": 50,
	"Value": 0,
	"Style": "Success",
	"Transitions": [
	{
	"AllowedRoles": ["Responder"],
	"AllowedInstanceRoles": [],
	"Description": "...",
	"Function": "SendResponse",
	"NextStates": [ "Respond" ],
	"DisplayName": "Send Response"
	}
	]
	},
	{
	"Name": "Respond",
	"DisplayName": "Respond",
	"Description": "...",
	"PercentComplete": 90,
	"Value": 1,
	"Style": "Success",
	"Transitions": [
	{
	"AllowedRoles": [],
	"AllowedInstanceRoles": ["Requestor"],
	"Description": "...",
	"Function": "SendRequest",
	"NextStates": [ "Request" ],
	"DisplayName": "Send Request"
	}
	]
	}
	]
	}
	]

[SimonGareis]

Hello  Can you send the Etherum coins on this adress  0xFBb85E92d42e7f00bf03A299874fa4Db816B5F7C Thanks Simon Gareis INB Philosophy LLC  Gesendet von Yahoo Mail auf Android Am Do., Feb. 22, 2024 at 8:32 schrieb ***@***.***>: - SendRequest and SendResponse do not satisfy its specifications. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/hello-blockchain/HelloBlockchain.sol#L25-L34 https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/hello-blockchain/HelloBlockchain.sol#L37-L44 As documented by its following specification, SendRequest is only available when previous message has been responded, a.k.a., Respond state while SendResponse is only available when there is a request message, a.k.a., Request state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/hello-blockchain/HelloBlockchain.json#L108-L147 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>