The oracle getter can run into issues when the contract exists, but the pool does not. Since it will throw an error and not be updating the costs.
Should add explicit check to make sure that the pool of interest is also directly available.
Also, seems like it is not consistent if getCode returns undefined or 0x for address without code, so checking that.
Actually, this can be a bit of a pain, because it would try to read values but get nothing back 😅 Also seeing some failures caused by this, but really not sure how it i) passed CI and ii) are not consistent.
Originally posted by @LHerskind in #19965 (comment)
The oracle getter can run into issues when the contract exists, but the pool does not. Since it will throw an error and not be updating the costs.
Should add explicit check to make sure that the pool of interest is also directly available.
Also, seems like it is not consistent if
getCodereturns undefined or0xfor address without code, so checking that.Actually, this can be a bit of a pain, because it would try to read values but get nothing back 😅 Also seeing some failures caused by this, but really not sure how it i) passed CI and ii) are not consistent.
Originally posted by @LHerskind in #19965 (comment)