From fb7317b62ce992ec1a6ec31c1e6badf6c8151ac3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1nos=20Benjamin=20Antal?=
 <antaljanosbenjamin@users.noreply.github.com>
Date: Tue, 3 Feb 2026 11:25:02 +0000
Subject: [PATCH] Merge pull request #95301 from mkmkme/aggegate-crash

Fix sparse column aggregation with sum() and timeseries
---
 src/AggregateFunctions/AggregateFunctionSum.h |  3 ++-
 ...arse_column_aggregation_with_sum.reference |  0
 ...811_sparse_column_aggregation_with_sum.sql | 21 +++++++++++++++++++
 3 files changed, 23 insertions(+), 1 deletion(-)
 create mode 100644 tests/queries/0_stateless/03811_sparse_column_aggregation_with_sum.reference
 create mode 100644 tests/queries/0_stateless/03811_sparse_column_aggregation_with_sum.sql

diff --git a/src/AggregateFunctions/AggregateFunctionSum.h b/src/AggregateFunctions/AggregateFunctionSum.h
index 2ce03c530c26..1d72ea447b85 100644
--- a/src/AggregateFunctions/AggregateFunctionSum.h
+++ b/src/AggregateFunctions/AggregateFunctionSum.h
@@ -566,7 +566,8 @@ class AggregateFunctionSum final : public IAggregateFunctionDataHelper<Data, Agg
         size_t to = std::lower_bound(offsets.begin(), offsets.end(), row_end) - offsets.begin();
 
         for (size_t i = from; i < to; ++i)
-            add(places[offsets[i]] + place_offset, &values, i + 1, arena);
+            if (places[offsets[i]])
+                add(places[offsets[i]] + place_offset, &values, i + 1, arena);
     }
 
     void merge(AggregateDataPtr __restrict place, ConstAggregateDataPtr rhs, Arena *) const override
diff --git a/tests/queries/0_stateless/03811_sparse_column_aggregation_with_sum.reference b/tests/queries/0_stateless/03811_sparse_column_aggregation_with_sum.reference
new file mode 100644
index 000000000000..e69de29bb2d1
diff --git a/tests/queries/0_stateless/03811_sparse_column_aggregation_with_sum.sql b/tests/queries/0_stateless/03811_sparse_column_aggregation_with_sum.sql
new file mode 100644
index 000000000000..7d6240b01f1d
--- /dev/null
+++ b/tests/queries/0_stateless/03811_sparse_column_aggregation_with_sum.sql
@@ -0,0 +1,21 @@
+CREATE TABLE 03811_sparse_column_aggregation_with_sum(key UInt128, val UInt16) ENGINE = MergeTree ORDER BY tuple();
+
+INSERT INTO 03811_sparse_column_aggregation_with_sum
+    SELECT number, number % 10000 = 0 FROM numbers(100000)
+    SETTINGS min_insert_block_size_rows = 1000,
+             max_block_size =1000,
+             max_threads = 2;
+
+SELECT key, sum(val) AS c
+FROM 03811_sparse_column_aggregation_with_sum
+GROUP BY key
+ORDER BY c DESC
+LIMIT 100
+FORMAT Null
+SETTINGS group_by_overflow_mode = 'any',
+         max_rows_to_group_by = 100,
+         group_by_two_level_threshold_bytes = 1,
+         group_by_two_level_threshold = 1,
+         max_threads = 2;
+
+DROP TABLE 03811_sparse_column_aggregation_with_sum;