From f4fbdf33f31c297ce9340314c5579004a506f966 Mon Sep 17 00:00:00 2001 From: Juan Munoz Date: Wed, 4 Mar 2026 16:18:03 -0300 Subject: [PATCH 1/5] fix: preemptive evaluation --- crates/block-producer/src/mempool/subscription.rs | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/crates/block-producer/src/mempool/subscription.rs b/crates/block-producer/src/mempool/subscription.rs index 8d0eb9094..1b67c9088 100644 --- a/crates/block-producer/src/mempool/subscription.rs +++ b/crates/block-producer/src/mempool/subscription.rs @@ -83,13 +83,9 @@ impl SubscriptionProvider { let network_notes = tx .output_notes() .filter_map(|note| match note { - // We check first to avoid cloning non-network notes. - OutputNote::Full(inner) => inner.is_network_note().then_some( - inner - .clone() - .into_account_target_network_note() - .expect("we just checked that this is a network note"), - ), + OutputNote::Full(inner) => { + inner.clone().into_account_target_network_note().ok() + }, _ => None, }) .collect(); From 9425f0559c80159e8bf0581886fa0fe9546ee884 Mon Sep 17 00:00:00 2001 From: Juan Munoz Date: Wed, 4 Mar 2026 16:31:07 -0300 Subject: [PATCH 2/5] chore: linting --- crates/block-producer/src/mempool/subscription.rs | 4 +--- crates/rpc/src/server/api.rs | 12 +++++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/crates/block-producer/src/mempool/subscription.rs b/crates/block-producer/src/mempool/subscription.rs index 1b67c9088..16e9d48da 100644 --- a/crates/block-producer/src/mempool/subscription.rs +++ b/crates/block-producer/src/mempool/subscription.rs @@ -83,9 +83,7 @@ impl SubscriptionProvider { let network_notes = tx .output_notes() .filter_map(|note| match note { - OutputNote::Full(inner) => { - inner.clone().into_account_target_network_note().ok() - }, + OutputNote::Full(inner) => inner.clone().into_account_target_network_note().ok(), _ => None, }) .collect(); diff --git a/crates/rpc/src/server/api.rs b/crates/rpc/src/server/api.rs index a0ec88859..1f887175d 100644 --- a/crates/rpc/src/server/api.rs +++ b/crates/rpc/src/server/api.rs @@ -534,11 +534,13 @@ fn endpoint_limits(params: &[(&str, usize)]) -> proto::rpc::EndpointLimits { /// Cached RPC query parameter limits. static RPC_LIMITS: LazyLock = LazyLock::new(|| { - use QueryParamAccountIdLimit as AccountId; - use QueryParamNoteIdLimit as NoteId; - use QueryParamNoteTagLimit as NoteTag; - use QueryParamNullifierLimit as Nullifier; - use QueryParamStorageMapKeyTotalLimit as StorageMapKeyTotal; + use { + QueryParamAccountIdLimit as AccountId, + QueryParamNoteIdLimit as NoteId, + QueryParamNoteTagLimit as NoteTag, + QueryParamNullifierLimit as Nullifier, + QueryParamStorageMapKeyTotalLimit as StorageMapKeyTotal, + }; proto::rpc::RpcLimits { endpoints: std::collections::HashMap::from([ From 3ff3c1240b23b9603d1522c4f56e2311fde8edc7 Mon Sep 17 00:00:00 2001 From: Juan Munoz Date: Wed, 4 Mar 2026 16:33:31 -0300 Subject: [PATCH 3/5] chore: bump path version --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index 9da92a6db..d1adbe991 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -31,7 +31,7 @@ license = "MIT" readme = "README.md" repository = "https://github.com/0xMiden/node" rust-version = "1.91" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" # Optimize the cryptography for faster tests involving account creation. [profile.test.package.miden-crypto] From 100a381c7e1dbc88c3fe88556c41c39ac36af1e7 Mon Sep 17 00:00:00 2001 From: Juan Munoz Date: Wed, 4 Mar 2026 16:51:49 -0300 Subject: [PATCH 4/5] fix: bump crate versions as well --- Cargo.lock | 34 +++++++++++++++++----------------- Cargo.toml | 26 +++++++++++++------------- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 6bc2f415f..e6cf0d856 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2820,7 +2820,7 @@ dependencies = [ [[package]] name = "miden-large-smt-backend-rocksdb" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "miden-crypto", "miden-protocol", @@ -2885,7 +2885,7 @@ dependencies = [ [[package]] name = "miden-network-monitor" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "axum", @@ -2914,7 +2914,7 @@ dependencies = [ [[package]] name = "miden-node" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "clap", @@ -2935,7 +2935,7 @@ dependencies = [ [[package]] name = "miden-node-block-producer" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "assert_matches", @@ -2971,7 +2971,7 @@ dependencies = [ [[package]] name = "miden-node-db" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "deadpool", "deadpool-diesel", @@ -2984,7 +2984,7 @@ dependencies = [ [[package]] name = "miden-node-grpc-error-macro" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "quote", "syn 2.0.114", @@ -2992,7 +2992,7 @@ dependencies = [ [[package]] name = "miden-node-ntx-builder" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "build-rs", @@ -3022,7 +3022,7 @@ dependencies = [ [[package]] name = "miden-node-proto" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "assert_matches", @@ -3048,7 +3048,7 @@ dependencies = [ [[package]] name = "miden-node-proto-build" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "build-rs", "fs-err", @@ -3059,11 +3059,11 @@ dependencies = [ [[package]] name = "miden-node-rocksdb-cxx-linkage-fix" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" [[package]] name = "miden-node-rpc" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "futures", @@ -3095,7 +3095,7 @@ dependencies = [ [[package]] name = "miden-node-store" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "assert_matches", @@ -3143,7 +3143,7 @@ dependencies = [ [[package]] name = "miden-node-stress-test" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "clap", "fs-err", @@ -3173,7 +3173,7 @@ dependencies = [ [[package]] name = "miden-node-utils" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "bytes", @@ -3200,7 +3200,7 @@ dependencies = [ [[package]] name = "miden-node-validator" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "aws-config", @@ -3301,7 +3301,7 @@ dependencies = [ [[package]] name = "miden-remote-prover" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "anyhow", "assert_matches", @@ -3339,7 +3339,7 @@ dependencies = [ [[package]] name = "miden-remote-prover-client" -version = "0.14.0-alpha.1" +version = "0.14.0-alpha.2" dependencies = [ "build-rs", "fs-err", diff --git a/Cargo.toml b/Cargo.toml index d1adbe991..98ee3c0af 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -46,22 +46,22 @@ debug = true [workspace.dependencies] # Workspace crates. -miden-large-smt-backend-rocksdb = { path = "crates/large-smt-backend-rocksdb", version = "=0.14.0-alpha.1" } -miden-node-block-producer = { path = "crates/block-producer", version = "=0.14.0-alpha.1" } -miden-node-db = { path = "crates/db", version = "=0.14.0-alpha.1" } -miden-node-grpc-error-macro = { path = "crates/grpc-error-macro", version = "=0.14.0-alpha.1" } -miden-node-ntx-builder = { path = "crates/ntx-builder", version = "=0.14.0-alpha.1" } -miden-node-proto = { path = "crates/proto", version = "=0.14.0-alpha.1" } -miden-node-proto-build = { path = "proto", version = "=0.14.0-alpha.1" } -miden-node-rpc = { path = "crates/rpc", version = "=0.14.0-alpha.1" } -miden-node-store = { path = "crates/store", version = "=0.14.0-alpha.1" } +miden-large-smt-backend-rocksdb = { path = "crates/large-smt-backend-rocksdb", version = "=0.14.0-alpha.2" } +miden-node-block-producer = { path = "crates/block-producer", version = "=0.14.0-alpha.2" } +miden-node-db = { path = "crates/db", version = "=0.14.0-alpha.2" } +miden-node-grpc-error-macro = { path = "crates/grpc-error-macro", version = "=0.14.0-alpha.2" } +miden-node-ntx-builder = { path = "crates/ntx-builder", version = "=0.14.0-alpha.2" } +miden-node-proto = { path = "crates/proto", version = "=0.14.0-alpha.2" } +miden-node-proto-build = { path = "proto", version = "=0.14.0-alpha.2" } +miden-node-rpc = { path = "crates/rpc", version = "=0.14.0-alpha.2" } +miden-node-store = { path = "crates/store", version = "=0.14.0-alpha.2" } miden-node-test-macro = { path = "crates/test-macro" } -miden-node-utils = { path = "crates/utils", version = "=0.14.0-alpha.1" } -miden-node-validator = { path = "crates/validator", version = "=0.14.0-alpha.1" } -miden-remote-prover-client = { path = "crates/remote-prover-client", version = "=0.14.0-alpha.1" } +miden-node-utils = { path = "crates/utils", version = "=0.14.0-alpha.2" } +miden-node-validator = { path = "crates/validator", version = "=0.14.0-alpha.2" } +miden-remote-prover-client = { path = "crates/remote-prover-client", version = "=0.14.0-alpha.2" } # Temporary workaround until # is part of `rocksdb-rust` release -miden-node-rocksdb-cxx-linkage-fix = { path = "crates/rocksdb-cxx-linkage-fix", version = "=0.14.0-alpha.1" } +miden-node-rocksdb-cxx-linkage-fix = { path = "crates/rocksdb-cxx-linkage-fix", version = "=0.14.0-alpha.2" } # miden-base aka protocol dependencies. These should be updated in sync. miden-block-prover = { version = "=0.14.0-alpha.1" } From a22f07b2b944ada9f8ceaeb9327135b47567ceab Mon Sep 17 00:00:00 2001 From: Juan Munoz Date: Wed, 4 Mar 2026 17:03:24 -0300 Subject: [PATCH 5/5] chore: fix linting due to rust version --- crates/rpc/src/server/api.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/crates/rpc/src/server/api.rs b/crates/rpc/src/server/api.rs index 1f887175d..a0ec88859 100644 --- a/crates/rpc/src/server/api.rs +++ b/crates/rpc/src/server/api.rs @@ -534,13 +534,11 @@ fn endpoint_limits(params: &[(&str, usize)]) -> proto::rpc::EndpointLimits { /// Cached RPC query parameter limits. static RPC_LIMITS: LazyLock = LazyLock::new(|| { - use { - QueryParamAccountIdLimit as AccountId, - QueryParamNoteIdLimit as NoteId, - QueryParamNoteTagLimit as NoteTag, - QueryParamNullifierLimit as Nullifier, - QueryParamStorageMapKeyTotalLimit as StorageMapKeyTotal, - }; + use QueryParamAccountIdLimit as AccountId; + use QueryParamNoteIdLimit as NoteId; + use QueryParamNoteTagLimit as NoteTag; + use QueryParamNullifierLimit as Nullifier; + use QueryParamStorageMapKeyTotalLimit as StorageMapKeyTotal; proto::rpc::RpcLimits { endpoints: std::collections::HashMap::from([